Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AccComplex::from_ptr as unsafe #85

Merged
merged 7 commits into from
Oct 27, 2024
Merged

Mark AccComplex::from_ptr as unsafe #85

merged 7 commits into from
Oct 27, 2024

Conversation

Ragarnoy
Copy link
Owner

@Ragarnoy Ragarnoy commented Oct 23, 2024

Fixes #84

Mark the AccComplex::from_ptr function as unsafe.

  • Add a safety comment to the AccComplex::from_ptr function explaining the potential risk of dereferencing a raw pointer.
  • Update the function signature to indicate it is unsafe.

Fixes #84

Mark the `AccComplex::from_ptr` function as `unsafe`.

* Add a safety comment to the `AccComplex::from_ptr` function explaining the potential risk of dereferencing a raw pointer.
* Update the function signature to indicate it is unsafe.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Ragarnoy/a121-rs/issues/84?shareId=XXXX-XXXX-XXXX-XXXX).
@Ragarnoy Ragarnoy merged commit 93dbea1 into main Oct 27, 2024
8 checks passed
@Ragarnoy Ragarnoy deleted the fix-unsafe-pointer branch October 27, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccComplex::from_ptr should be unsafe
1 participant